Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: datagrid row size accessibility v1 #3479

Merged
merged 4 commits into from
Sep 18, 2023
Merged

fix: datagrid row size accessibility v1 #3479

merged 4 commits into from
Sep 18, 2023

Conversation

davidmenendez
Copy link
Contributor

Contributes to #3241

@davidmenendez davidmenendez requested a review from a team as a code owner September 15, 2023 18:23
@netlify
Copy link

netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for v1-carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 9c845c1
🔍 Latest deploy log https://app.netlify.com/sites/v1-carbon-for-ibm-products/deploys/65086daf6363b3000820ebaf
😎 Deploy Preview https://deploy-preview-3479--v1-carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

elycheea
elycheea requested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard looks good but hopefully minor change request —

Row size dropdown should align right as the other toolbar items do.
image

We removed getDropdownPosition(), but I think we can probably use CSS to accomplish this?

@davidmenendez
Copy link
Contributor Author

@elycheea updated

@elycheea elycheea merged commit b64787b into carbon-design-system:main_v1 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elycheea elycheea elycheea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carbon for IBM Products
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmenendez @elycheea